-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement to full screen functionality of widgets #2808
Comments
@meganindya Please share your opinions on this classification. Thanks |
The matrix in the Music Keyboard could be appropriately sized. There is free space at the bottom. Should be an easy fix. |
Hey @ksraj123 @meganindya, can we add the feature to maximize the widget on Double-Clicking the top-bar of the widget....just as in Windows and Ubuntu systems? |
Hey @meganindya... |
Hi @ksraj123, can we also enhance the full-screen functionality of the phrasemaker widget by utilizing the blank space just as in musickeyboard widget? |
@daksh4469 We could do that but I don't think there's really a need for that because unlike the music keyboard, the widget window for phrasemaker expands to accommodate all the rows n columns even in non-fullscreen mode, which makes the fullscreen mode useful for very few use cases where the matrix is too large to fit on the screen. Scaling the cells themselves in fullscreen mode would not be a good idea as the number of rows n columns are not fixed. But we should enable horizontal and vertical scrolling in fullscreen mode if the table is overflowing which should be an easy fix. Please share your thoughts on this @meganindya |
@ksraj123 Any widget which I can pick to work on? Thanks. |
@khushal87 Since this issue is somewhat old, most of the widgets are done. Either the fullscreen functionality is already implemented, or is under review or is lying in local awaiting some finishing touches. Will be opening PRs for pitchDrumMatrix and temperament soon as they are almost done, after the current PRs are merged. Please feel free to explore MusicBlocks and look for issues. Thanks |
I checked widgets like "custom mode" and "tempo" and they seem unscaled in full-screen mode. Are they ought to be the same? |
@khushal87 |
Attempted implementing an enhancement for the pitchdrum widget for full screen functionality. Code changes made to the display, alignment, and flex direction in order to fix the scaling to full-screen. Added code that changed the styles of the widget and the attributes within the scale function. Feb 4 ticket sugarlabs#2808
Is this issue is resolved . can i start working on this issue |
Hi I am new to the Opensource Coding and would like to start my journey with this organisation. I am well versed with Python, Html, Java CSS, Django Frame work. I need guidance for the same. Thanks in advance. |
@ksraj123 Should I work on it if it's still not resolved? |
@ksraj123 please assign me this issue : Pitch drum matrix |
if its not resolve please assign this issue to me |
We have the ability to go full screen now and perhaps some widgets could take better advantage of the additional screen real estate. But we can tackle them individually in new tickets. |
Currently only a few widgets make good use of the extra space in full screen mode. Ideally we want the fullscreen mode to be meaningful for all widgets, however for some widgets fullscreen mode does not bring any benefits and for them the same could be disabled. Since we are moving to music blocks 2 widgets that require too much work to be adapted to the fullscreen mode could be left out.
Widgets whose fullscreen mode could be enhanced
Widgets for which fullscreen mode should be disabled
Widgets which should be left as they are
References:
#2761 (comment)
Please share feedback and suggestions.
The text was updated successfully, but these errors were encountered: