Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz example project #3398

Merged
merged 5 commits into from
Dec 10, 2023
Merged

Conversation

JustinFrost47
Copy link
Contributor

@JustinFrost47 JustinFrost47 commented Dec 5, 2023

This Pull request addresses the issue: #3327

I added a html file crossword-puzzle.html which runs a crossword puzzle game as described. Based on instructions from @pikurasa , this is based off https://musicblocks.sugarlabs.org/index.html?id=1699191323362045&run=True that nice framework which uses a heap to store characters of answers.
So, changing or creating new quizzes are as simple (just change word characters from answer - action_block and change question text, answer variable, hint text and word length from 'setQaHeap' - action block ) instructions are also included in a action block named 'doc'

I really had fun learning new music concepts and working with musicblocks. This is my first real-world opensource contribution, so if you would like to share some suggestions/ areas of improvement, I am happy to learn

@JustinFrost47 JustinFrost47 changed the title Crossword puzzle example project added Crossword puzzle example project Dec 6, 2023
@JustinFrost47
Copy link
Contributor Author

@pikurasa could you kindly review this

@pikurasa
Copy link
Collaborator

pikurasa commented Dec 8, 2023

@pikurasa could you kindly review this

I'll check it out soon.

@pikurasa
Copy link
Collaborator

pikurasa commented Dec 9, 2023

It works well.

Two points of quick feedback:

  • I'd much rather avoid the "deaf" question on these quizzes; please find another question to do there instead
  • When it plays back the pitches, it currently plays them back backwards; you may need to use "reverse heap" block, but please have the playback perform the pitches in the correct order

@JustinFrost47
Copy link
Contributor Author

JustinFrost47 commented Dec 9, 2023

@pikurasa Sorry, I didnt notice them properly

I used a counter variable and index heap block to resolve that issue
now the pitches are played in the correct order

I have made the required changes and double checked them for any issues

@walterbender
Copy link
Member

This version works well. But since it is a quiz, not a crossword, the file name should be updated?

@pikurasa
Copy link
Collaborator

@walterbender I tested it and I think we could merge it into examples now.

I could think of some improvements, but I think this is a great start.

Do you have additional feedback?

@pikurasa
Copy link
Collaborator

This version works well. But since it is a quiz, not a crossword, the file name should be updated?

Oh yes; agreed.

@JustinFrost47
Copy link
Contributor Author

Done 👍 I have changed the filename

@JustinFrost47
Copy link
Contributor Author

@walterbender , @pikurasa accidentally closed the pr, now i have reopened it
I have changed the filename

@walterbender walterbender merged commit e7acdb5 into sugarlabs:master Dec 10, 2023
@JustinFrost47 JustinFrost47 changed the title Crossword puzzle example project Quiz example project Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants