Removed depricated unescape #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterbender plz review |
|
Maybe it makes more sense to look for an update ot jquery? |
|
shall we upgrade jquery to 3.7.1 latest version |
|
Let's try it and see it anything breaks. |
|
@walterbender i had downloaded the 3.7.1 min.js and the uncompressed one and added the required scripts in index.html.Is this the way we should do it or we should use cdn ,since the 3.7.1.js is huge in size |
|
How did you test this? |
|
After upgrading it I didn't encounter any errors in the console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of #3585