Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added musical example of double sharps and flats #3855 #3872

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions guide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ This guide details the many musical features of the language.
2. [Pitch Transformations](#32-pitch-transformations)
1. [Step Pitch Block](#321-step-pitch-block)
2. [Sharps and Flats](#322-sharps-and-flats)
1. [Double Sharps and Flats](#3221-double-sharps-and-flats)
3. [Adjusting Transposition](#323-adjusting-transposition)
4. [Summary of Pitch Movements](#324-summary-of-pitch-movements)
5. [Set Key](#325-set-key)
Expand Down Expand Up @@ -369,6 +370,27 @@ block `Mi` is lowered by one half step; on the right, both *Pitch*
blocks are raised by one half step. (You can also use a double-sharp
or double-flat accidental.)


#### <a name= "DOUBLE-SHARPS-AND-FLATS">3.2.2.1 Double Sharps And Flats</a>

Double sharps and flats, although not very common, are used in music
notation to accurately represent pitches that are altered by two
semitones. They arise in compositions that explore chromaticism,
modulations to distant keys, or non-traditional scales where such
alterations are necessary for harmonic or melodic purposes. Double
sharps and flats help maintain the correct intervals, ensuring
precise notation and clarity of musical expression.

![double sharp and flat](./transform1_1.png "Using Double Sharp and Flat blocks")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to using the "accidental override", I think you should add examples of selecting those accidentals from the pie menu as follows:

Screenshot from 2024-04-22 16-00-19
Screenshot from 2024-04-22 16-01-18
Screenshot from 2024-04-22 16-01-32


![la campanella](./transform1_2.png "La Campanella - Liszt")

![mikrokosmos](./transform1_3.png "Mikrokosmos V Nr. 131 - Bartók")

The example on the left shows how to play the double sharp as played in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the text, it refers to examples on the left and right. However, they display for me above and below. Perhaps just refer to them as first and second example, or, if you can, add captions underneath and refer to them as "the example by Liszt" and "the example by Bartok".

Screenshot from 2024-04-22 16-02-37

measure 6 of Liszt's La Campanella. The example on the right shows how to
play the double flat harmony in measure 6 of Bartók's Mikrkosmos V, Nr. 131.

#### <a name="ADJUST-TRANSPOSITION">3.2.3 Adjusting Transposition</a>

![transposition](./transform2.svg "Adjusting transpositions")
Expand Down
Binary file added guide/transform1_1.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added guide/transform1_2.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added guide/transform1_3.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.