Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added musical example of double sharps and flats #3855 #3872

Closed
wants to merge 6 commits into from

Conversation

byoojh
Copy link

@byoojh byoojh commented Apr 21, 2024

Added a section in the guide under the sharps and flat to describe use cases of double sharps and flats, along with some well known musical examples.

@pikurasa pikurasa self-requested a review April 22, 2024 19:55
@pikurasa
Copy link
Collaborator

I'm assuming this is ready for review, so I'm checking it out.

@pikurasa
Copy link
Collaborator

It's going well so far. Two comments:

  1. Accidentals

In addition to using the "accidental override", I think you should add examples of selecting those accidentals from the pie menu as follows:

Screenshot from 2024-04-22 16-00-19
Screenshot from 2024-04-22 16-01-18
Screenshot from 2024-04-22 16-01-32

  1. Left/right

In the text, it refers to examples on the left and right. However, they display for me above and below. Perhaps just refer to them as first and second example, or, if you can, add captions underneath and refer to them as "the example by Liszt" and "the example by Bartok".

Screenshot from 2024-04-22 16-02-37

Copy link
Collaborator

@pikurasa pikurasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are very close. Please the suggested few changes to get all the way.

sharps and flats help maintain the correct intervals, ensuring
precise notation and clarity of musical expression.

![double sharp and flat](./transform1_1.png "Using Double Sharp and Flat blocks")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to using the "accidental override", I think you should add examples of selecting those accidentals from the pie menu as follows:

Screenshot from 2024-04-22 16-00-19
Screenshot from 2024-04-22 16-01-18
Screenshot from 2024-04-22 16-01-32


![mikrokosmos](./transform1_3.png "Mikrokosmos V Nr. 131 - Bartók")

The example on the left shows how to play the double sharp as played in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the text, it refers to examples on the left and right. However, they display for me above and below. Perhaps just refer to them as first and second example, or, if you can, add captions underneath and refer to them as "the example by Liszt" and "the example by Bartok".

Screenshot from 2024-04-22 16-02-37

Copy link

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jul 25, 2024
Copy link

Closed pull request due to inactivity for more than 63 days.

@github-actions github-actions bot closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants