-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added musical example of double sharps and flats #3855 #3872
Conversation
I'm assuming this is ready for review, so I'm checking it out. |
It's going well so far. Two comments:
In addition to using the "accidental override", I think you should add examples of selecting those accidentals from the pie menu as follows:
In the text, it refers to examples on the left and right. However, they display for me above and below. Perhaps just refer to them as first and second example, or, if you can, add captions underneath and refer to them as "the example by Liszt" and "the example by Bartok". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are very close. Please the suggested few changes to get all the way.
sharps and flats help maintain the correct intervals, ensuring | ||
precise notation and clarity of musical expression. | ||
|
||
![double sharp and flat](./transform1_1.png "Using Double Sharp and Flat blocks") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
![mikrokosmos](./transform1_3.png "Mikrokosmos V Nr. 131 - Bartók") | ||
|
||
The example on the left shows how to play the double sharp as played in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Closed pull request due to inactivity for more than 63 days. |
Added a section in the guide under the sharps and flat to describe use cases of double sharps and flats, along with some well known musical examples.