Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home view activity start-new using Alt key does not work #780

Closed
quozl opened this issue Jan 10, 2018 · 5 comments
Closed

Home view activity start-new using Alt key does not work #780

quozl opened this issue Jan 10, 2018 · 5 comments

Comments

@quozl
Copy link
Contributor

quozl commented Jan 10, 2018

Reproducer: start an activity, stop it, view the home view activity ring, observe the activity icon now has user colour, press and hold the alt key, observe that user colour is removed, click on the icon, release the alt key.

Expected result; activity is started new.

Observed result; no response, no errors logged.

Workaround; right-click, choose start new.

Does not occur on Fedora 18.

Does occur on Ubuntu 16.04, and 18.04 beta.

@quozl
Copy link
Contributor Author

quozl commented Jan 14, 2018

@Pro-Panda, there was an e-mail to me from GitHub saying you would like to work on this, but the comment is missing from this issue. Is this a regression of GitHub, or did you delete? If you deleted, was there something ambiguous about the issue that needs more details?

@rhl-bthr
Copy link

@quozl
I deleted and forgot to write the updated one. Sorry
So this was what I found:

  • alt+click is not handled by any layer of button-press-event or any other signal in Sugar. Hence this

Observed result; no response, no errors logged.

  • It then goes to the underlying OS(on Ubuntu 16.04) and is used to move the window(rdesktop) by dragging the mouse
  • II am trying to override it in the same way as Alt+Tab is done.

Do you think I might be on the correct lines ?

@quozl
Copy link
Contributor Author

quozl commented Jan 16, 2018

No, wrong lines altogether. HomeWindow.__key_press_event_cb is where the alt key press is detected, and it saves state using set_resume_mode; a method of HomeBox.

@rhl-bthr
Copy link

rhl-bthr commented Jan 16, 2018

@quozl Sorry, my previous statement might be ambiguous.
This is what I found.
While reproducing the issue,

  1. Press alt: detected by HomeWindow.__key_press_event_cb
  2. Keep holding alt
  3. Clicking on any button after that; button-press-event is not detected by any layer of widgets via any signal
  4. Release alt: detected by HomeWindow.__key_release_event_cb

Proposed Reason - Mouse cursor changes during 3 to one of dragging the window(rdesktop), as thats a feature of Ubuntu provided for any window
Supporting Statement - I couldn't reproduce this issue when I log into Sugar Desktop Environment instead of Ubuntu Desktop Environment at the login page of ubuntu. It creates a new activity in that case.

@quozl
Copy link
Contributor Author

quozl commented Jan 16, 2018

Thanks for the investigation. I agree. For me, symptom only occurs on VM (virt-manager, VirtualBox) under wmaker, and there is no change of cursor image, but the virtual machine window can be dragged.

Symptom does not occur on native hardware.

@quozl quozl closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants