-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sugar Labs logo size #278
Comments
Unable to reproduce. Tested Firefox on Ubuntu 16.04, and Firefox and Safari on iPad with iOS 12. The logo correctly appears on Firefox and does not look stretched. The logo does not appear on Safari. Please provide browser, operating system, and display resolution details. |
@quozl Yes, it is working fine on Ubuntu 18.04 too, tried Firefox and Chrome. Display resolutions are |
browser - Chrome |
@Gabbar8055, which version of Chrome? |
Chrome-Version 71.0.3578.98 |
Thanks. Reproduced on Chrome 71.0.3578.80 on Ubuntu 16.04 by shrinking the window in various ways. About 800x600 yields a thinner logo. About 600x800 yields logo over navigation area. But it all still works; what is the problem with the size changes of the logo? |
I think it would look better if the logo does not come out of the navigation bar in 600x800 resolution and also a little bit less thin in 800x600 resolution. What do you think @quozl ? |
Thanks. I don't think it matters. Our critical problem is with content, not presentation. Visitors are not staying on the page for very long, and they don't learn what we do. I'll ask again; what is the problem with the size changes of the logo? You've said it would look better; but how would it look better? @sugarlabs/a-b |
Thanks for review the issue. If you think the presentation does not matter that much then its OK! and there is no problem with the size changes of the logo. The issue is only about the presentation of the logo. |
I have managed to reproduce this. When the page is loaded with a large format, a green icon is shown. Dynamically changing the size of the window down to a point where it goes into dropdown mode causes the logo to grow outside of the navigation bar. However, loading the page in a smaller format, an orange logo is shown instead. Changing the size of the window then has the logo grow and shrink properly. An easy fix is to retain the orange logo no matter what size screen on page load, or to use the same logo resizing CSS with the green logo as well. Right now, the green logo has a fixed size no matter what size, that's why it falls off the navigation bar. |
Wouldn't it be easier to bring in the upstream changes to the theme or undo changes to the theme that were made since it was last brought in from upstream? |
Stale, closing. |
The size of sugar labs logo looks stretched on large-size devices.
The size of sugar labs logo on medium-size devices is getting out of navigation bar.
The text was updated successfully, but these errors were encountered: