Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugar Labs logo size #278

Closed
mayankkuthar opened this issue Dec 8, 2018 · 12 comments
Closed

Sugar Labs logo size #278

mayankkuthar opened this issue Dec 8, 2018 · 12 comments

Comments

@mayankkuthar
Copy link

The size of sugar labs logo looks stretched on large-size devices.
22
The size of sugar labs logo on medium-size devices is getting out of navigation bar.
21

@quozl
Copy link
Contributor

quozl commented Dec 12, 2018

Unable to reproduce. Tested Firefox on Ubuntu 16.04, and Firefox and Safari on iPad with iOS 12. The logo correctly appears on Firefox and does not look stretched. The logo does not appear on Safari.

Please provide browser, operating system, and display resolution details.

@aryanharitsh123
Copy link

@quozl Yes, it is working fine on Ubuntu 18.04 too, tried Firefox and Chrome. Display resolutions are
1366x768 and 1920x1080.

@mayankkuthar
Copy link
Author

browser - Chrome
operating system - Windows7 Ultimate (64 bit)
display resolution - 1366x768
The problem occurs when you zoom in by 110%.

@quozl
Copy link
Contributor

quozl commented Dec 12, 2018

@Gabbar8055, which version of Chrome?

@mayankkuthar
Copy link
Author

Chrome-Version 71.0.3578.98

@quozl
Copy link
Contributor

quozl commented Dec 13, 2018

Thanks. Reproduced on Chrome 71.0.3578.80 on Ubuntu 16.04 by shrinking the window in various ways. About 800x600 yields a thinner logo. About 600x800 yields logo over navigation area. But it all still works; what is the problem with the size changes of the logo?

@mayankkuthar
Copy link
Author

I think it would look better if the logo does not come out of the navigation bar in 600x800 resolution and also a little bit less thin in 800x600 resolution. What do you think @quozl ?

@quozl
Copy link
Contributor

quozl commented Dec 14, 2018

Thanks. I don't think it matters. Our critical problem is with content, not presentation. Visitors are not staying on the page for very long, and they don't learn what we do. I'll ask again; what is the problem with the size changes of the logo? You've said it would look better; but how would it look better?

@sugarlabs/a-b

@mayankkuthar
Copy link
Author

Thanks for review the issue. If you think the presentation does not matter that much then its OK! and there is no problem with the size changes of the logo. The issue is only about the presentation of the logo.

@makandz
Copy link

makandz commented Jan 1, 2019

I have managed to reproduce this.

When the page is loaded with a large format, a green icon is shown. Dynamically changing the size of the window down to a point where it goes into dropdown mode causes the logo to grow outside of the navigation bar. However, loading the page in a smaller format, an orange logo is shown instead. Changing the size of the window then has the logo grow and shrink properly.

An easy fix is to retain the orange logo no matter what size screen on page load, or to use the same logo resizing CSS with the green logo as well. Right now, the green logo has a fixed size no matter what size, that's why it falls off the navigation bar.

@quozl
Copy link
Contributor

quozl commented Jan 1, 2019

Wouldn't it be easier to bring in the upstream changes to the theme or undo changes to the theme that were made since it was last brought in from upstream?

@quozl
Copy link
Contributor

quozl commented Oct 9, 2019

Stale, closing.

@quozl quozl closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants