-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiview() chooses the maximum lag based on the number of predictor columns used, regardless of E. #44
Comments
Dear Uriah, Thank you for your use and analysis of rEDM. Having looked at your examples, it appears you have identified a bug where the value of I have found and corrected the problem. The fix is uploaded to github as version 1.7.5. Regarding parameters
Also, please note that there is no guarantee that all lags will be present in the selected views. That is, with E = 3, which embeds each Your first example has 2-dimensional views, since the number of columns is 2 and D is not specified:
Your second example has 3-D views for the same reason:
The third example, you set
With D not specified, Your other question: Yes, that is (now) possible. An example:
Thank you again for your diligence and analysis of rEDM! JP |
Hi Joseph, Best |
On https://cran.r-project.org/web/packages/rEDM/vignettes/rEDM-tutorial.pdf in the description of function Multiview there is written:
Multiview() operates by constructing all possible embeddings of dimension E with lag up to E-1
.I have noticed that the function behaves oddly in that regard, namely it chooses the maximum lag to be equal to the number of predictor columns used, regardless of other parameter values. I'm showing this with some examples:
example 1: 2 predictor columns and E=3
As can be seen, the lag is indeed E-1=2, but the the dimensions of the single views are 2 and not 3.
example 2: 3 predictor columns and E=3
In this case the dimensions of each view is indeed 3, but the max lag is not E-1=2 but it is 3.
example 3: 4 predictor columns and E=3
In this case neither the embedding dimension nor the maximum makes sense: each view is of dimension 4 and the maximum lag is also 4.
The pattern is quite obvious: Embedding dimension = maximum lag = number of columns.
I don't think this is intended, as following the description it should be: maximum lag = Embedding dimension-1; and both the maximum lag and E are independent from the number of predictor columns (to an extent).
I am also confused regarding the 2 arguments E (embedding dimension) and D (multivariate dimension). What exactly is the difference? D seems to overwrite E, meaning that if D ist set, the value of E has no influence and the maximum lag is still chosen based on the number of predictor columns. Example:
Max lag is 2 (= number of predictors), and 3 variables are used for each view (= D)
Same as above, changing E did nothing.
Also, why is the maximum lag set to E-1? I would like the possibility of constructing a model in which each view is e.g. of size 2 and the maximum lag is 3. That is, I would like to have the possibility of choosing the dimension of the views and the maximum lag separately. Is that possible?
Thank you and best regards,
Uriah
sessionInfo(package = "rEDM")
The text was updated successfully, but these errors were encountered: