Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version 1.0 of the http crate? #144

Closed
sugyan opened this issue Mar 22, 2024 · 0 comments · Fixed by #152
Closed

Upgrade to version 1.0 of the http crate? #144

sugyan opened this issue Mar 22, 2024 · 0 comments · Fixed by #152

Comments

@sugyan
Copy link
Owner

sugyan commented Mar 22, 2024

The http crate version was upgraded to v1 in the recent reqwest v0.12.0 release.
https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md#v0120

I'm considering upgrading http to v1 on atrium-xrpc along with this, but isahc, which can be used with atrium-xrpc-client, still depends on 0.2, and it seems it will be a few more months before isahc upgrades to v1.0, as discussed in this issue
sagebind/isahc#432

  • Maintain the current configuration unchanged until isahc supports http v1.0.
  • Temporarily remove the feature that depends on the isahc client until an updated isahc version becomes available.
  • Consider alternative approaches.

This note serves as a reminder of the current situation and the decisions that need consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant