Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove beforeLint #35

Closed
simonsmith opened this issue Sep 20, 2016 · 3 comments
Closed

Remove beforeLint #35

simonsmith opened this issue Sep 20, 2016 · 3 comments
Assignees
@simonsmith
Milestone
3.0.0

Comments

@simonsmith
Copy link
Member

I feel like this feature is probably unused and adds a lot of complexity to the preprocessor. I think it would also fix #27.

The only use case I had before was to unwrap nested rules for the bem-linter but it handles that out of the box now.

Thoughts?
@giuseppeg
Copy link
Member

I am ok with dropping it. @timkelty ?

@giuseppeg giuseppeg mentioned this issue Sep 21, 2016
Closed
@timkelty
Copy link
Member

OK with me.

@simonsmith
Copy link
Member Author

Gonna pick this up

@simonsmith simonsmith self-assigned this Sep 21, 2016
simonsmith added a commit that referenced this issue Sep 22, 2016
@simonsmith
Remove beforeLint feature
4eda09e 
This was an underused feature and adds complexity to the preprocessor.
This could be solved more elegantly by allowing the user to pass their
own `transform` function to postcss-import.

Fixes #35
@simonsmith simonsmith mentioned this issue Sep 22, 2016
Merged
simonsmith added a commit that referenced this issue Sep 22, 2016
@simonsmith
Remove beforeLint feature
ba1399e 
This was an underused feature and adds complexity to the preprocessor.
This could be solved more elegantly by allowing the user to pass their
own `transform` function to postcss-import.

Fixes #35

Improve variable naming

This makes it a little clearer what `merged` is

Remove superfluous comments

These are too basic to need comments
@giuseppeg giuseppeg modified the milestone: 3.0.0 Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonsmith simonsmith

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@timkelty @simonsmith @giuseppeg