Remove beforeLint #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonsmith looks good. You left a few expect(stdout).to.not.contain('beforeLint ran');assertions that we should remove. |
|
Good spot! Removed |
|
Feel free to Squash and merge if tests pass |
This was an underused feature and adds complexity to the preprocessor. This could be solved more elegantly by allowing the user to pass their own `transform` function to postcss-import. Fixes #35 Improve variable naming This makes it a little clearer what `merged` is Remove superfluous comments These are too basic to need comments
* Run lint after tests as often code style is broken intentionally during refactoring * Reduce duplication of mocha watch
simonsmith
force-pushed
the
beforelint-refactor
branch
from
c64ef84
to
bea8ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
Also played around with a solution to #36 and it should be pretty easy, and also allow a
beforeLintstyle feature anyway.