New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge 1 Feedback #1

Closed

meredithcat opened this issue Jul 25, 2019 · 1 comment

meredithcat commented Jul 25, 2019 •

edited

Loading

Challenge 1 Feedback: 6/20
Feedback based on Challenge 1 Rubric

Solution: 0
- Does not run on sample input without errors
Documentation: 2
- Include input/output and runtime in docstrings
- Remove commented out code to improve clarity
Organization: 3
- Put main challenge_1 code in a main function rather than in global scope
- Suggestion: Remove "main" code from graph.py
Testing: 1
- Add tests for Graph and file handling

aespaldi commented Aug 17, 2019

RESUBMIT
Challenge 1 Feedback :

Overall: 13/20 Pass

Feedback based on Challenge 1 Rubric:

Works: 6
Documentation: 2
- No attribution given for code copied from tutorial sample (add a line at the top)
Code Organization: 3
Testing: 2

Sukhrobjon closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment