Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all children before adding as constituents #365

Closed
mjgiarlo opened this issue Sep 4, 2019 · 0 comments · Fixed by #366
Closed

Validate all children before adding as constituents #365

mjgiarlo opened this issue Sep 4, 2019 · 0 comments · Fixed by #366
Assignees
@mjgiarlo
Labels
enhancement
Projects
Infrateam Aug-Sep 2019

Comments

@mjgiarlo
Copy link
Member

mjgiarlo commented Sep 4, 2019 •
edited

Validate all children early before touching any objects and fail fast if any children can't be combined.

Blocks sul-dlss/argo#1463
@mjgiarlo mjgiarlo self-assigned this Sep 4, 2019
@mjgiarlo mjgiarlo added this to Ready in Infrateam Aug-Sep 2019 via automation Sep 4, 2019
@ndushay ndushay mentioned this issue Sep 4, 2019
Closed
@mjgiarlo mjgiarlo moved this from Ready to In progress in Infrateam Aug-Sep 2019 Sep 4, 2019
mjgiarlo added a commit that referenced this issue Sep 5, 2019
@mjgiarlo
Add ItemQueryService.validate_combinable_items
0ef98ae 
Refs #365

This new class method takes an array of druids and makes sure each is combinable. If any are not, a hash of errors is created and returned.
mjgiarlo added a commit that referenced this issue Sep 5, 2019
@mjgiarlo
Validate all items to be combined before modifying any of them
0fa9186 
Refs #365
mjgiarlo added a commit that referenced this issue Sep 5, 2019
@mjgiarlo
Raise exception from objects controller when constituent service raises
d1894f7 
Refs #365
@mjgiarlo mjgiarlo mentioned this issue Sep 5, 2019
Merged
mjgiarlo added a commit that referenced this issue Sep 5, 2019
@mjgiarlo
Validate constituents before creating virtual object
d2bcc7b 
Fixes #365

Includes:
* Add `ItemQueryService.validate_combinable_items`. This new class method takes an array of druids and makes sure each is combinable. If any are not, a hash of errors is created and returned.
* Validate all items to be combined before modifying any of them
* Return HTTP 422 when constituent service returns errors
Infrateam Aug-Sep 2019 automation moved this from In progress to Done Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjgiarlo mjgiarlo

Labels
enhancement
Projects
No open projects
Infrateam Aug-Sep 2019
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate constituents before creating virtual object sul-dlss/dor-services-app
1 participant
@mjgiarlo