Validate constituents before creating virtual object #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Sep 5, 2019
app/services/item_query_service.rb
Outdated
| @@ -11,6 +11,20 @@ def initialize(id:, item_relation: default_item_relation) | |||
|
|
|||
| delegate :allows_modification?, to: :item | |||
|
|
|||
| # @param [Array] druids a list of druids | |||
| # @raises [RuntimeError] if any items are dark, citation_only, or not modifiable | |||
There was a problem hiding this comment.
It does not. Good 👁️. This was from a prior implementation I worked on. Removing.
jcoyne
reviewed
Sep 5, 2019
jcoyne
reviewed
Sep 5, 2019
Fixes #365 Includes: * Add `ItemQueryService.validate_combinable_items`. This new class method takes an array of druids and makes sure each is combinable. If any are not, a hash of errors is created and returned. * Validate all items to be combined before modifying any of them * Return HTTP 422 when constituent service returns errors
mjgiarlo
force-pushed
the
validate_constituents_365
branch
from
d1894f7
to
d2bcc7b
Compare
|
@jcoyne this is ready for another look now. Thanks for the review! |
jcoyne
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365
Includes:
ItemQueryService.validate_combinable_items. This new class method takes an array of druids and makes sure each is combinable. If any are not, a hash of errors is created and returned.