Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionController::HttpAuthentication Refactoring #221

Merged
merged 2 commits into from
Sep 21, 2017
Merged

ActionController::HttpAuthentication Refactoring #221

merged 2 commits into from
Sep 21, 2017

Conversation

aaron-collier
Copy link
Contributor

This replaces #154 with a rebased and updated version.

@coveralls
Copy link

coveralls commented Sep 19, 2017

Coverage Status

Coverage increased (+0.2%) to 95.6% when pulling 6cf1afe on rebased_154 into ea643fb on master.

@aaron-collier
Copy link
Contributor Author

https://github.com/sul-dlss/stacks/blob/rebased_154/spec/features/iiif_spec.rb#L17

The current spec error is the result of the current_user in the call above looks like:
#<User:0x007fc29d96a430 @ip_address="127.0.0.1", @anonymous_locatable_user=true>

Causing the token auth to fails because an anonymous_locatable_user is not a token_eligible_user. Thoughts/feedback from @mejackreed here?

@cbeer
Copy link
Member

cbeer commented Sep 19, 2017

Does Bearer on line 17 need to be Token to match the upstream change?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.707% when pulling 0d4a471 on rebased_154 into 61435d1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.707% when pulling 0d4a471 on rebased_154 into 61435d1 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.707% when pulling 8225a1a on rebased_154 into 61435d1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.707% when pulling 8225a1a on rebased_154 into 61435d1 on master.

@aaron-collier aaron-collier changed the title [WIP] ActionController::HttpAuthentication Refactoring ActionController::HttpAuthentication Refactoring Sep 20, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.707% when pulling 452372b on rebased_154 into 61435d1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.707% when pulling 452372b on rebased_154 into 61435d1 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants