default use of Bearer for authorization token in auth scheme, for III… #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on UAT with UV |
…F Auth compliance
mejackreed
force-pushed
the
use-bearer-token-for-iiif-auth
branch
from
f5bf1e4
to
07cc7ec
Compare
cbeer
reviewed
Apr 3, 2018
| @@ -8,7 +8,7 @@ def create | |||
| @message = if token | |||
| { | |||
| accessToken: token, | |||
| tokenType: 'Token', | |||
| tokenType: 'Bearer', | |||
There was a problem hiding this comment.
I think tokenType is gone in IIIF Auth 1.0; I'm not sure if we had backwards compatibility concerns that led us to keep it as-is?
There was a problem hiding this comment.
Yeah I hadn't realized that. /shrug should we remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…F Auth compliance
Fixes sul-dlss/sul-embed#827
Fixes sul-dlss/sul-embed#856
This change fixes a regression introduced in #221 . The regression switched usage of the authorization header prefix from
BearertoToken.Beareris required via the IIIF Auth spec and we were not honoring it anymore.This change should be backwards compatible now accepting both.