Added handling for institutions that have ampersands when querying pu… #1060
Conversation
| end | ||
|
|
||
| it 'generates the correct term string' do | ||
| expect(query_author.send(:term)).to eq('((Altman Russ[Author]) OR (Altman R[Author])) AND (Stanford University[Affiliation] OR William Mary[Affiliation] OR William and Mary[Affiliation])') |
There was a problem hiding this comment.
Are we confident the extra and isn't going to screw up the query parser? Is there a way to designate "William and Mary" is one token rather than 3?
There was a problem hiding this comment.
Determined this approach by testing as described in #1059, which isn't to say that there are not other ways of formulating the query.
There was a problem hiding this comment.
I see we're doing \"oregon\"[MeSH Terms] would it be possible to do \"William & Mary\"[Affiliation]?
There was a problem hiding this comment.
I tried various variations with escaped quoting, escaping the ampersand, and using parentheses to no avail.
There was a problem hiding this comment.
it appears we already have some code that is doing something similar for the WoS search, this class: https://github.com/sul-dlss/sul_pub/blob/master/lib/agent/author_institution.rb
It is stripping things like "and" and "university". It is used here to construct a list of institutions to add to the query:
https://github.com/sul-dlss/sul_pub/blob/master/lib/web_of_science/query_author.rb#L40-L42
Thoughts on re-using this logic? The reason we ended up stripping "University" and "Institution" and "College" in WoS queries is I believe for a similar reason (it was picking up extra stuff), perhaps not a problem for Pubmed. But wanted to acknowledge a bit of duplication here for consideration.
|
…bmed.
closes #1059