Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate db_tests pass/fail fields #37

Closed
sullo opened this issue Nov 27, 2012 · 2 comments
Closed

Consolidate db_tests pass/fail fields #37

sullo opened this issue Nov 27, 2012 · 2 comments

Comments

@sullo
Copy link
Owner

sullo commented Nov 27, 2012

Regular expressions invalidate the need for multiple pass/fail match fields in db_tests. We should consolidate them to a single match field and a single fail field. A single field for each will let us do easy alternation for pass or fail matching, but keep us from having to use fairly expensive lookarounds for negative matching and both pass/fail conditions.

@iasdeoupxe
Copy link
Contributor

Noticed this while getting familiar with the syntax of the db_tests as well.

I think this could be a good improvement for the db_tests because e.g. the "Match 1 Or" is mostly unused.

@sullo
Copy link
Owner Author

sullo commented May 30, 2021

Won't do.

@sullo sullo closed this as completed May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants