Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap targetObject and sourceObject in MergerInterfaces #124

Open
alexander-schranz opened this issue Mar 19, 2020 · 0 comments
Open

Swap targetObject and sourceObject in MergerInterfaces #124

alexander-schranz opened this issue Mar 19, 2020 · 0 comments
Labels
DX Only affecting the end developer
Milestone
Stable Release

Comments

@alexander-schranz
Copy link
Member

In https://github.com/sulu/SuluContentBundle/pull/123/files we renamed the MergerInterface parameters to merge(object $targetObject, object $sourceObject). Maybe it would make more sense to swap the parameters merge(object $sourceObject, object $targetObject). Feels more natural for me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX Only affecting the end developer
Projects
None yet
Milestone
Stable Release
Development

No branches or pull requests
1 participant
@alexander-schranz