Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hreflang tag generation broken for unpublished articles #587

Closed
popoplanter opened this issue Jul 23, 2021 · 2 comments
Closed

hreflang tag generation broken for unpublished articles #587

popoplanter opened this issue Jul 23, 2021 · 2 comments
Assignees

Comments

@popoplanter
Copy link
Contributor

popoplanter commented Jul 23, 2021

Q A
Bug? yes
New Feature? no
SuluArticleBundle Version 2.3.1
Sulu Version 2.3.0

Actual Behavior

In article pages an unpublished page for a localization causes the other localizations to generate hreflang tags linking to that unpuplished page. Only if the article for the localization is deleted, the hreflang tag also gets deleted. If an article is created for the first time and no other localization version for the article exists, the hreflang tags are correct.

Expected Behavior

Just like in normal pages, articles should not be generating hreflang tags for unpublished articles.

Steps to Reproduce

create an article and a version of the same article in another language. then unpublish one of them and check the hreflang tags on the other one. it should be removed and not linking to a 404 page of the unpublished articles.

Possible Solutions

Fix the "alternate" in "localizations" property from true to false when unpublishing an article.

currently its like this:
Bildschirmfoto 2021-07-22 um 16 45 39

should be like this:
Bildschirmfoto 2021-07-22 um 16 45 10

@niklasnatter
Copy link
Contributor

@C-burr Thanks for reporting! Could you check if #589 fixes the issue in your project?

@luca-rath
Copy link
Contributor

@C-burr Should be fixed now and will be released as 2.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants