Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the README information #28

Closed
rluders opened this issue Oct 16, 2020 · 2 comments
Closed

Verify the README information #28

rluders opened this issue Oct 16, 2020 · 2 comments
Assignees
Labels
bug 🐛 Something isn't working documentation 📑 Improvements or additions to documentation

Comments

@rluders
Copy link
Contributor

rluders commented Oct 16, 2020

Description

I was checking the README instructions, and it seems that some commands are not working. For example the one for e2e tests. In this case, I think that would be better to verify all the instructions, and also standardize the commands.

Expected behavior

All the commands should be working.

Additional context

We also need to give some option, like, you can run it with yarn or npm

@rluders rluders added bug 🐛 Something isn't working documentation 📑 Improvements or additions to documentation labels Oct 16, 2020
@marianyfs marianyfs self-assigned this Oct 5, 2021
@marianyfs
Copy link
Contributor

I updated some README.md instructions when I added Cypress AXE and Storybook, tested all the commands and was able to run successfully (using yarn)

@rluders
Copy link
Contributor Author

rluders commented Oct 6, 2021

So, I guess that we are good. Thank you.

@rluders rluders closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working documentation 📑 Improvements or additions to documentation
Projects
Development

No branches or pull requests

2 participants