We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following two lines expect that the server will close the connection, but in my understanding http2 specification doesn't state that, rather I think it expects the sender of GOAWAY frame will close the connection, because GOAWAY frame is used to notify the peer that the sender will initiate closing the connection. What do you think? https://github.com/summerwind/h2spec/blob/master/generic/3_8_goaway.go#L30 https://github.com/summerwind/h2spec/blob/master/http2/7_error_codes.go#L27
The text was updated successfully, but these errors were encountered:
Correct. These test cases are invalid. However, I belive that sending a GOAWAY frame is useful for server testing. So I'd like to fix this to send PING frame after GOAWAY frame like other test case. https://github.com/summerwind/h2spec/blob/master/client/4_1_frame_format.go#L28-L31
Sorry, something went wrong.
Fixed in v2.2.0.
No branches or pull requests
The following two lines expect that the server will close the connection, but in my understanding http2 specification doesn't state that, rather I think it expects the sender of GOAWAY frame will close the connection, because GOAWAY frame is used to notify the peer that the sender will initiate closing the connection. What do you think?
https://github.com/summerwind/h2spec/blob/master/generic/3_8_goaway.go#L30
https://github.com/summerwind/h2spec/blob/master/http2/7_error_codes.go#L27
The text was updated successfully, but these errors were encountered: