Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDs for Indicators are not static #1

Open
fmssn opened this issue Feb 14, 2023 · 9 comments
Open

IDs for Indicators are not static #1

fmssn opened this issue Feb 14, 2023 · 9 comments

Comments

@fmssn
Copy link

fmssn commented Feb 14, 2023

Obviously as the JSON API is undocumented, they are not bound to the IDs static. I got a rude awakening when this morning my reachability indicators suddenly changed to unemployment rates.

This is clearly not in your responsibility, yet I think it would be beneficial to add this information to the readme, just so people should increase their test coverage to cover this possible problem.

@sumtxt
Copy link
Owner

sumtxt commented Feb 14, 2023

Not sure I follow. Can you explain what changed?

@fmssn
Copy link
Author

fmssn commented Feb 14, 2023

As an example, previously, the average driving time to the next airport was accessible by calling
get_variables(theme="335", geography="KRE"). Now this instead gives "Nicht erwerbsfähige SGBII-Leistungsberechtigte unter 15 Jahren je 100 Einwohner unter 15 Jahren", whatever that means. Instead it is now accessible by calling get_variables(theme="346", geography="KRE").

@fmssn
Copy link
Author

fmssn commented Feb 14, 2023

Such changes were prevalent with next to all indicators I am using.

@sumtxt
Copy link
Owner

sumtxt commented Feb 14, 2023

Oh, ok! Thanks for sharing. I will put a note in the Readme.

@bathyscapher
Copy link

I likely would have overlooked this and would have ended up with wrong data, if the ID used so far (get_data(variable = '111', geography = "GVB") would not have been completely vanished.

Is there a way to fix the IDs to a certain variable?

Or is KurznamePlus invariant? So it would be possible to dynamically fetch the ID by a variable name (such as fetch the ID of Einwohner unter 6 Jahre).

@sumtxt
Copy link
Owner

sumtxt commented Feb 22, 2023

This is not an issue with the package but their (undocumented) API.

@bathyscapher
Copy link

I see. Do you know if the values of KurznamePlus remains the same over time?

@sumtxt
Copy link
Owner

sumtxt commented Feb 22, 2023

I don't know.

@bathyscapher
Copy link

Okay, thank you though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants