Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom Button styles #2373

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix custom Button styles #2373

merged 2 commits into from
Jan 3, 2024

Conversation

connor-baer
Copy link
Member

Purpose

The refactor of the Button styles seems to have changed the order of the bundled CSS, thus causing issues with Button style overrides in other components.

Approach and changes

  • Increase the specificity of Button style overrides

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jan 3, 2024
@connor-baer connor-baer requested a review from a team as a code owner January 3, 2024 17:01
Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 824b2d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 5:33pm

@connor-baer connor-baer changed the title Fix button style specificity Fix custom Button styles Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9a6287c) 96.78% compared to head (824b2d8) 96.73%.
Report is 3 commits behind head on canary.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2373      +/-   ##
==========================================
- Coverage   96.78%   96.73%   -0.05%     
==========================================
  Files         227      227              
  Lines       18847    18878      +31     
  Branches     1174     1176       +2     
==========================================
+ Hits        18241    18262      +21     
- Misses        593      603      +10     
  Partials       13       13              
Files Coverage Δ
...n/components/MobileNavigation/MobileNavigation.tsx 100.00% <100.00%> (ø)
.../components/SidePanel/components/Header/Header.tsx 100.00% <100.00%> (ø)
.../circuit-ui/components/ButtonGroup/ButtonGroup.tsx 89.47% <77.77%> (-10.53%) ⬇️

@connor-baer connor-baer merged commit 5e66931 into canary Jan 3, 2024
10 of 12 checks passed
@connor-baer connor-baer deleted the fix/button-specificity branch January 3, 2024 22:22
This was referenced Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant