feat(styles): extract static style #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #477 +/- ##
=========================================
+ Coverage 76.15% 79.55% +3.4%
=========================================
Files 167 167
Lines 2453 2460 +7
Branches 435 443 +8
=========================================
+ Hits 1868 1957 +89
+ Misses 467 387 -80
+ Partials 118 116 -2
|
connor-baer
force-pushed
the
feature/static-style-extraction
branch
from
e9aed56
to
67dc9af
Compare
|
I'm so excited about this! I'm gonna take it for the test drive tomorrow |
connor-baer
force-pushed
the
feature/static-style-extraction
branch
2 times, most recently
from
4ee21e7
to
c11630d
Compare
connor-baer
changed the title
connor-baer
force-pushed
the
feature/static-style-extraction
branch
from
95c9743
to
741b874
Compare
fernandofleury
approved these changes
Sep 30, 2019
connor-baer
requested review from
cristianoliveira
and removed request for
mlent
connor-baer
force-pushed
the
feature/static-style-extraction
branch
from
f0e332c
to
a8bd8de
Compare
connor-baer
force-pushed
the
feature/static-style-extraction
branch
from
a8bd8de
to
02bd4fd
Compare
|
🎉 This PR is included in version 1.2.2-canary.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479.
Purpose
There are some frontend projects at SumUp that can't or don't use React. They need to implement all styles from scratch and need to be updated separately. This would be solved if we could somehow get the styles from the React components as plain CSS. This is exactly what static style extraction aims to achieve.
🔗 Proposal
🔗 Docs
🔗 Example file (GitHub doesn't allow the upload of
.cssfiles, so you need to change the file type from.txtto.css)Approach and changes
CacheProviderto extract the static styles$ yarn static-styles --help Options: --theme The name of the theme to use. [options: "circuit"] [default: "circuit"] --components A comma separated list of the components to include. Also supports "all" or "none". [array] [default: "all"] --global Whether to include global styles. [boolean] [default: false] --customProperties Whether to use CSS custom properties (variables). [boolean] [default: false] --pretty Whether the CSS should be formatted with prettier. [boolean] [default: false] --filePath Path to the file where the stylesheet should be saved, relative to the current directory. [string] --help Show help [boolean] --version Show the version [boolean]Todo
Definition of done