feat(components): add sidebar separator component #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmetral
requested review from
fernandofleury,
connor-baer and
afonsodelgado
Codecov Report
@@ Coverage Diff @@
## canary #514 +/- ##
==========================================
+ Coverage 79.65% 79.67% +0.02%
==========================================
Files 172 173 +1
Lines 2477 2480 +3
Branches 445 445
==========================================
+ Hits 1973 1976 +3
Misses 388 388
Partials 116 116
|
fernandofleury
approved these changes
Dec 5, 2019
connor-baer
requested changes
Dec 5, 2019
connor-baer
approved these changes
Dec 5, 2019
|
🎉 This PR is included in version 1.6.0-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a horizontal separator component to the Sidebar. This will be used to group items together and is particularly useful when information architectures become more complex.
Approach and changes
Add a styled component in the Sidebar that extends the Circuit
Hrcomponent, just changing the color.Definition of done