Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TradingEngineServiceImpl.java ZeusEngineService.java 的cancelOrder函数签名容易误解 #40

Closed
ssh352 opened this issue Nov 27, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@ssh352
Copy link

ssh352 commented Nov 27, 2018

screen shot 2018-11-27 at 5 29 02 pm

TradingEngineServiceImpl implements ZeusEngineService ,这两个class都有cancelOrder

void cancelOrder(String originalOrderID) ;
void cancelOrder(String rtOrderID);

一个传递的是rtOrderID 另一个传递的是originalOrderID 这两个是完全不一样的两个ID

能否改一改 让其一致 避免用户传递错误的参数?

@sun0x00 sun0x00 added the enhancement New feature or request label Nov 27, 2018
@sun0x00
Copy link
Owner

sun0x00 commented Jan 6, 2019

2019-01-06从dev分支合并至master分支的代码已经解决此问题。此问题将关闭,如有疑问请再次激活,谢谢。

@sun0x00 sun0x00 closed this as completed Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants