Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix claude login #771

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

asyncButNeverAwaits
Copy link
Contributor

@asyncButNeverAwaits asyncButNeverAwaits commented Mar 29, 2024

Fix not able to get org after login.

Found that org is now store in cookie instead of local storage.

Add org in setting, in case new changes and user can update

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 8:21am

@sunner
Copy link
Owner

sunner commented Mar 30, 2024

Thank you for fixing. I have only one question: why add back the brandId setting?

@asyncButNeverAwaits
Copy link
Contributor Author

Thank you for fixing. I have only one question: why add back the brandId setting?

hi @sunner, in case the claude update again then we can update org in setting

@sunner
Copy link
Owner

sunner commented Apr 1, 2024

This setting will confuse most users. Moreover, the param is not changed frequently. Could you remove the setting?

@asyncButNeverAwaits
Copy link
Contributor Author

This setting will confuse most users. Moreover, the param is not changed frequently. Could you remove the setting?

@sunner done

@asyncButNeverAwaits asyncButNeverAwaits marked this pull request as draft April 2, 2024 08:19
@asyncButNeverAwaits asyncButNeverAwaits marked this pull request as ready for review April 2, 2024 08:19
@sunner sunner merged commit 62bd092 into sunner:main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants