-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would like to submit simple feature request? (Stop button) #19
Comments
Sure @awongCM, feel free to send any pull request you would like! It's a good idea to ask upfront about your ideas, too. For this idea of "stop button" it could make a nice addition, but for me "pause" and "stop" are the same thing. I don't see the need to have a "stop" button when I can just "pause". What is your use case? |
Thanks @sunny I went away thinking about this for a while. I thought it would be nice to include extra controls to the already web interface controls as it stands. I would like the user to feel as though they can fully use all the music play options as if it were their faviourite music player of any vendor ie Itunes, Amarok etc. With this mind, I thought about laying out the web interface control to make it look like a remote control. Just like you have for your home entertainment system. Perhaps like a widget-type interface or something similar? |
Sorry if I didn't actually answer your question about the stop button. That was just purely an example, not an actual implementation I would like to do as main feature. that I would like to contribute to so-nice - really! |
Adding more buttons would certainly be useful! Go for it! |
Thanks @sunny! ::) |
Closing this issue in favour of PR #20 |
for eg. I would like to add a stop button on the interface since I notice there isn't any.
Do you mind if I make the changes on my local dev machine, commit and push it for you to review it?
Let me know if that works for you. Cause this is my first time I actually want to actively participate in open-source projects.
Thanks.
The text was updated successfully, but these errors were encountered: