Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to submit simple feature request? (Stop button) #19

Closed
awongCM opened this issue Jul 7, 2014 · 6 comments
Closed

Would like to submit simple feature request? (Stop button) #19

awongCM opened this issue Jul 7, 2014 · 6 comments
Labels

Comments

@awongCM
Copy link

awongCM commented Jul 7, 2014

for eg. I would like to add a stop button on the interface since I notice there isn't any.

Do you mind if I make the changes on my local dev machine, commit and push it for you to review it?

Let me know if that works for you. Cause this is my first time I actually want to actively participate in open-source projects.

Thanks.

@sunny
Copy link
Owner

sunny commented Jul 7, 2014

Sure @awongCM, feel free to send any pull request you would like! It's a good idea to ask upfront about your ideas, too.

For this idea of "stop button" it could make a nice addition, but for me "pause" and "stop" are the same thing. I don't see the need to have a "stop" button when I can just "pause". What is your use case?

@sunny sunny changed the title Would like to submit simple feature request? Would like to submit simple feature request? (Stop button) Jul 7, 2014
@awongCM
Copy link
Author

awongCM commented Jul 8, 2014

Thanks @sunny

I went away thinking about this for a while.

I thought it would be nice to include extra controls to the already web interface controls as it stands. I would like the user to feel as though they can fully use all the music play options as if it were their faviourite music player of any vendor ie Itunes, Amarok etc.

With this mind, I thought about laying out the web interface control to make it look like a remote control. Just like you have for your home entertainment system.

Perhaps like a widget-type interface or something similar?

@awongCM
Copy link
Author

awongCM commented Jul 8, 2014

Sorry if I didn't actually answer your question about the stop button.

That was just purely an example, not an actual implementation I would like to do as main feature. that I would like to contribute to so-nice - really!

@sunny
Copy link
Owner

sunny commented Jul 8, 2014

Adding more buttons would certainly be useful! Go for it!

@awongCM
Copy link
Author

awongCM commented Jul 10, 2014

Thanks @sunny! ::)

@sunny
Copy link
Owner

sunny commented Dec 16, 2014

Closing this issue in favour of PR #20

@sunny sunny closed this as completed Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants