Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of double digit years in parse_time with _time_string_parse_format set #2000

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Fix parsing of double digit years in parse_time with _time_string_parse_format set #2000

merged 2 commits into from
Feb 17, 2017

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Feb 10, 2017

this is a small oversight from #1967

@Cadair Cadair added Affects Dev An issue/bug that affects master [BugFix] labels Feb 10, 2017
@pep8speaks
Copy link

Hello @Cadair! Thanks for submitting the PR.

@Cadair
Copy link
Member Author

Cadair commented Feb 10, 2017

ALSO BOOM ISSUE 2000

Alex-Ian-Hamilton
Alex-Ian-Hamilton approved these changes Feb 17, 2017
View reviewed changes
Copy link
Contributor

@Alex-Ian-Hamilton Alex-Ian-Hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for the older goes data.
Code seems correct,

@Cadair Cadair merged commit 4d2f430 into sunpy:master Feb 17, 2017
@Cadair Cadair deleted the double_digit_year branch February 17, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Ian-Hamilton Alex-Ian-Hamilton Alex-Ian-Hamilton approved these changes

Assignees
No one assigned
Labels
Affects Dev An issue/bug that affects master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cadair @pep8speaks @Alex-Ian-Hamilton