Migrate to Astropy Time

.circleci/config.yml

@@ -43,6 +43,9 @@ jobs:
     docker:
       - image: quay.io/pypa/manylinux1_i686
     steps:
+      - restore_cache:
+          keys: sample-data-v1
+
       - checkout
       - run: *skip-check
       - run:

.gitignore

@@ -210,3 +210,5 @@ docs/api/
 docs/whatsnew/latest_changelog.txt
 # This is incase you run the figure tests
 figure_test_images*
+
+tags

.travis.yml

@@ -42,7 +42,7 @@ matrix:
         apt:
           packages:
             - httpie
-      stage: "Cron jobs"
+      stage: "Comprehensive jobs"
 
     - name: "NumPy dev (py37-numpydev)"
       addons:

azure-pipelines.yml

@@ -14,11 +14,11 @@ jobs:
     os: macos
     tox: py37-offline
 
-- template: azure-templates.yml
-  parameters:
-    name: Windows_36_offline
-    os: windows
-    tox: py36-offline
+#- template: azure-templates.yml
+#  parameters:
+#    name: Windows_36_offline
+#    os: windows
+#    tox: py36-offline
 
 - template: azure-templates.yml
   parameters:

changelog/2611.breaking.rst

@@ -0,0 +1 @@
+Make ``sunpy.time.parse_time`` return ``astropy.time.Time`` instead of ``datetime.datetime``.

changelog/2638.breaking.rst

@@ -0,0 +1 @@
+The properties and methods of ``sunpy.time.TimeRange`` returns ``astropy.time.Time`` and ``astropy.time.TimeDelta`` instead of ``datetime.datetime`` and ``datetime.timedelta`` respectively.

changelog/2676.breaking.rst

@@ -0,0 +1 @@
+`obstime` keyword param of ``sunpy.instr.goes._goes_lx`` takes a non-scalar ``astropy.time.Time`` object instead of ``np.array``. The precision of times contained in sunpy `timeseries` has been increased to 9 from 6.

changelog/2679.bugfix.rst

@@ -0,0 +1 @@
+``sunpy.instr.fermi.met_to_utc`` now returns the correct utc time which takes into account the leap seconds that have passed.

changelog/2694.breaking.rst

@@ -0,0 +1 @@
+Removed ``sunpy.net.jsoc.attrs.Time`` because it served the same purpose as ``sunpy.net.attrs.Time`` after the switch to ``astropy.time.Time``.

docs/code_ref/coordinates.rst

@@ -127,10 +127,10 @@ coordinates is::
 
    >>> c = SkyCoord(0*u.arcsec, 0*u.arcsec, frame=frames.Helioprojective, obstime="2017-07-26")
    >>> c
-   <SkyCoord (Helioprojective: obstime=2017-07-26 00:00:00, rsun=695508.0 km, observer=<HeliographicStonyhurst Coordinate for 'earth'>): (Tx, Ty) in arcsec
+   <SkyCoord (Helioprojective: obstime=2017-07-26T00:00:00.000, rsun=695508.0 km, observer=<HeliographicStonyhurst Coordinate for 'earth'>): (Tx, Ty) in arcsec
        (0., 0.)>
    >>> c.transform_to(frames.HeliographicCarrington)
-   <SkyCoord (HeliographicCarrington: obstime=2017-07-26 00:00:00): (lon, lat, radius) in (deg, deg, km)
+   <SkyCoord (HeliographicCarrington: obstime=2017-07-26T00:00:00.000): (lon, lat, radius) in (deg, deg, km)
       (283.99298362, 5.31701821, 695508.00000058)>
 
 It is also possible to transform to any coordinate system implemented in Astropy. This can be used to find the position of the solar limb in AltAz equatorial coordinates::
@@ -257,14 +257,14 @@ If you want to obtain a un-realized coordinate frame corresponding to a
   >>> from sunpy.data.sample import AIA_171_IMAGE  # doctest: +REMOTE_DATA
   >>> amap = sunpy.map.Map(AIA_171_IMAGE)  # doctest: +REMOTE_DATA
   >>> amap.observer_coordinate  # doctest: +REMOTE_DATA
-    <SkyCoord (HeliographicStonyhurst: obstime=2011-06-07 06:33:02.770000): (lon, lat, radius) in (deg, deg, m)
+    <SkyCoord (HeliographicStonyhurst: obstime=2011-06-07T06:33:02.770): (lon, lat, radius) in (deg, deg, m)
         (0., 0.048591, 1.51846026e+11)>
 
 which is equivalent to::
 
   >>> from astropy.wcs.utils import wcs_to_celestial_frame # doctest: +REMOTE_DATA
   >>> wcs_to_celestial_frame(amap.wcs)  # doctest: +REMOTE_DATA
-    <Helioprojective Frame (obstime=2011-06-07 06:33:02.770000, rsun=696000000.0 m, observer=<HeliographicStonyhurst Coordinate (obstime=2011-06-07 06:33:02.770000): (lon, lat, radius) in (deg, deg, m)
+    <Helioprojective Frame (obstime=2011-06-07T06:33:02.770, rsun=696000000.0 m, observer=<HeliographicStonyhurst Coordinate (obstime=2011-06-07T06:33:02.770): (lon, lat, radius) in (deg, deg, m)
         (0., 0.048591, 1.51846026e+11)>)>
 
 

docs/code_ref/time.rst

@@ -1,8 +1,8 @@
 SunPy time
 ==========
 
-The time submodule contains helpers for converting strings to Python
-`datetime.datetime` objects and handling common operations on these objects. As
+The time submodule contains helpers for converting strings to
+`astropy.time.Time` objects and handling common operations on these objects. As
 well as this a `~sunpy.time.TimeRange` object is provided for representing a
 period of time and performing operations on that range.
 

docs/dev_guide/documentation.rst

@@ -225,7 +225,7 @@ Example (:class:`sunpy.map.Map`) ::
     ----------
     header : dict
         A dictionary representation of the image header
-    date : datetime
+    date : `astropy.time.Time`
         Image observation time
     det : str
         Detector name

docs/guide/acquiring_data/database.rst

@@ -1,3 +1,7 @@
+.. The tests in the module are very fragile to change in ordering of VSO
+   results. In their current form they are very hard to maintain.
+ .. doctest-skip-all
+
 .. _database_guide:
 
 --------------------------

docs/guide/acquiring_data/hek.rst

@@ -304,7 +304,7 @@ HEK results and create the corresponding VSO query attributes.
 
     >>> vso_query = hek2vso.translate_results_to_query(result[10:11])  # doctest: +REMOTE_DATA
     >>> vso_query[0]  # doctest: +REMOTE_DATA
-    [<Time(datetime.datetime(2011, 8, 9, 7, 22, 44), datetime.datetime(2011, 8, 9, 7, 28, 56), None)>, <Source('SDO')>, <Instrument('AIA')>, <Wavelength(193.0, 193.0, 'Angstrom')>]
+    [<Time(<Time object: scale='utc' format='isot' value=2011-08-09T07:22:44.000>, <Time object: scale='utc' format='isot' value=2011-08-09T07:28:56.000>, None)>, <Source('SDO')>, <Instrument('AIA')>, <Wavelength(193.0, 193.0, 'Angstrom')>]
 
 This function allows users finer-grained control of VSO queries
 generated from HEK results.

docs/guide/acquiring_data/jsoc.rst

@@ -64,7 +64,7 @@ between January 1st from 00:00 to 01:00, 2014.
 We can add email address to the search query with the :mod:`jsoc.Notify` attribute.
 Please note you can search without this but right now, you can not add the email address after the search.
 
-    >>> res = Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.Series('hmi.v_45s'),
+    >>> res = Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.Series('hmi.v_45s'),
     ...                   a.jsoc.Notify('sunpy@sunpy.org'))  # doctest: +REMOTE_DATA
 
 This returns an `~sunpy.net.fido_factory.UnifiedResponse` object containing
@@ -108,7 +108,7 @@ variable set to the Fido search, in this case, res::
 
 
 Now, let's break down the arguments of ``Fido.search`` to understand
-better what we've done.  The first argument ``a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00')``
+better what we've done.  The first argument ``a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00')``
 sets the start and end times for the query (any date/time
 format understood by SunPy's :ref:`parse_time function <parse-time>`
 can be used to specify dates and time). The Time attribute takes UTC time,
@@ -119,7 +119,7 @@ pass an Astropy Time object, like::
 
 Then, the Time attribute can be passed as::
 
-    >>> a.jsoc.Time(astropy.time.Time('2014-01-01T00:00:00', scale='tai'), astropy.time.Time('2014-01-01T01:00:00', scale='tai'))  # doctest: +SKIP
+    >>> a.Time(astropy.time.Time('2014-01-01T00:00:00', scale='tai'), astropy.time.Time('2014-01-01T01:00:00', scale='tai'))  # doctest: +SKIP
 
 The second argument::
 
@@ -132,7 +132,7 @@ The notion is that a JSOC query has a set of attribute objects, imported as ``a.
 that are specified to construct the query.
 
 ``a.jsoc.Series()`` is compulsory to be provided in each of the jsoc queries. Apart from this,
-at least one PrimeKey must be passed (generally ``a.jsoc.Time()``).
+at least one PrimeKey must be passed (generally ``a.Time()``).
 
 The third argument::
 
@@ -147,7 +147,7 @@ Other than Time, one other PrimeKey is supported with in-built attribute.
 In case of AIA series, ``a.jsoc.Wavelength()`` can be passed as a PrimeKey::
 
     >>> import astropy.units as u
-    >>> res = Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
+    >>> res = Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
     ...                               a.jsoc.Notify('sunpy@sunpy.org'),
     ...                               a.jsoc.Series('aia.lev1_euv_12s'),
     ...                               a.jsoc.Wavelength(304*u.AA))  # doctest: +REMOTE_DATA
@@ -164,7 +164,7 @@ If 2 or more PrimeKeys need to be passed together::
 Also, note that the pre-defined primekeys, Time and Wavelength can also be passed as above, but you need to
 specify the exact keyword for it. For e.g. by::
 
-    >>> a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.PrimeKey('WAVELNTH', '161')  # doctest: +SKIP
+    >>> a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.PrimeKey('WAVELNTH', '161')  # doctest: +SKIP
 
 If the correct keyword is not specified, or the passed PrimeKey is not supported by the given series, a
 meaningful error will be thrown, which will give you the PrimeKeys supported by that series. Hence, by looking
@@ -186,7 +186,7 @@ object. These default keywords are ``'DATE'``, ``'TELESCOP'``, ``'INSTRUME'``, `
 If you want to get a manual set of keywords in the response object, you can pass the set of keywords using
 `~sunpy.net.jsoc.attrs.Keys` attribute.
 
-    >>> res = Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
+    >>> res = Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
     ...                   a.jsoc.Series('hmi.v_45s'), a.jsoc.Notify('sunpy@sunpy.org'),
     ...                   a.jsoc.Keys(['TELESCOP', 'INSTRUME', 'T_OBS']))  # doctest: +REMOTE_DATA
 
@@ -226,7 +226,7 @@ A list of supported segments of a series, say ``hmi.sharp_720s`` can be obtained
 Also, if you provide an incorrect segment name, it will throw a meaningful error, specifying which segment values are supported
 by the given series::
 
-    >>> Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
+    >>> Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
     ...             a.jsoc.Series('hmi.sharp_720s'), a.jsoc.Notify('sunpy@sunpy.org'),
     ...             a.jsoc.Segment('image'))  # doctest: +REMOTE_DATA
     Traceback (most recent call last):
@@ -236,7 +236,7 @@ by the given series::
 
 To get files for more than 1 segment at the same time, chain ``a.jsoc.Segment()`` using ``AND`` operator::
 
-    >>> Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
+    >>> Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
     ...             a.jsoc.Series('hmi.sharp_720s'), a.jsoc.Notify('sunpy@sunpy.org'),
     ...             a.jsoc.Segment('continuum') & a.jsoc.Segment('magnetogram'))  # doctest: +REMOTE_DATA +ELLIPSIS
     <sunpy.net.fido_factory.UnifiedResponse object at ...>
@@ -278,7 +278,7 @@ using `~sunpy.net.attrs.Sample`. In other words, if you need to query for ``hmi.
 between January 1st from 00:00 to 01:00, 2014, every 10 minutes, you can do::
 
     >>> import astropy.units as u
-    >>> Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.Notify('sunpy@sunpy.org'),
+    >>> Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.Notify('sunpy@sunpy.org'),
     ...             a.jsoc.Series('hmi.v_45s'), a.Sample(10*u.min))  # doctest: +REMOTE_DATA +ELLIPSIS
     <sunpy.net.fido_factory.UnifiedResponse object at ...>
     Results from 1 Provider:
@@ -307,7 +307,7 @@ Complex queries can be built using ``OR`` operators.
 
 Let's look for 2 different series data at the same time::
 
-    >>> Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.Notify('sunpy@sunpy.org'),
+    >>> Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'), a.jsoc.Notify('sunpy@sunpy.org'),
     ...             a.jsoc.Series('hmi.v_45s') | a.jsoc.Series('aia.lev1_euv_12s'))  # doctest: +REMOTE_DATA +ELLIPSIS
     <sunpy.net.fido_factory.UnifiedResponse object at ...>
     Results from 2 Providers:
@@ -371,8 +371,8 @@ This is the ``OR`` operator.  Think of the above query as setting a set
 of conditions which get passed to the JSOC.  Let's say you want all the
 ``hmi.v_45s`` data from two separate days::
 
-    >>> Fido.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00') |
-    ...             a.jsoc.Time('2014-01-02T00:00:00', '2014-01-02T01:00:00'),
+    >>> Fido.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00') |
+    ...             a.Time('2014-01-02T00:00:00', '2014-01-02T01:00:00'),
     ...             a.jsoc.Series('hmi.v_45s'), a.jsoc.Notify('sunpy@sunpy.org'))  # doctest: +REMOTE_DATA +ELLIPSIS
     <sunpy.net.fido_factory.UnifiedResponse object at ...>
     Results from 2 Providers:
@@ -476,7 +476,7 @@ We can add an email address to the search query with the :mod:`jsoc.Notify` attr
 Please note you can search without this but right now, you can not add the email address after the search::
 
     >>> from sunpy.net import attrs as a
-    >>> res = client.search(a.jsoc.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
+    >>> res = client.search(a.Time('2014-01-01T00:00:00', '2014-01-01T01:00:00'),
     ...                     a.jsoc.Series('hmi.v_45s'),
     ...                     a.jsoc.Notify('sunpy@sunpy.org'))  # doctest: +REMOTE_DATA
 

docs/guide/roi.rst

@@ -19,9 +19,9 @@ This creates an roi called result for the specific time range. Querying the newl
     >>> result
     SunPy Region-of-interest (ROI) object
     -------------------------------------
-    Source:         LYRA LYTAF
-    Start time:     2011-02-15T04:34:09
-    End time:       2011-02-15T04:48:21
-    Event description:  UV occult.
+    Source:            LYRA LYTAF
+    Start time:        2011-02-15 04:34:09.000
+    End time:          2011-02-15 04:48:21.000
+    Event description: UV occult.
 
 Check out the code reference for the time range object for more information.