-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rsun_obs property to return a quantity #3099
Conversation
Hello @MSKirk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-05-14 14:21:41 UTC |
Thanks for the pull request @MSKirk! Everything looks great! |
Any chance of a test and a changelog entry? |
Codecov Report
@@ Coverage Diff @@
## master #3099 +/- ##
==========================================
- Coverage 89.96% 89.86% -0.11%
==========================================
Files 148 148
Lines 10557 10564 +7
==========================================
- Hits 9498 9493 -5
- Misses 1059 1071 +12
Continue to review full report at Codecov.
|
Done. |
Thanks! |
This has been missing for a long time. Ugh. Thanks for fixing this @MSKirk. As a general comment, it might be worth someone's time to go through all our other map sources to find out which properties fall back on defaults, and then to find out if this is justified. |
Conda build failure is unrelated to the PR. |
Description
Added rsun_obs property to stereo map sources. It returns a quantity in arcsec consistent with other Maps and overwrites mapbase's assumption of a photospheric limb as seen from Earth.