Added APE14 support in SunPy visualization #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @yashrsharma44! Everything looks great! |
Cadair
reviewed
Jul 22, 2019
|
@yashrsharma44 is this read to go as is, or have you not yet worked through it all with the bugs in the wcsaxes branch etc? |
|
A slight change needs to be done, replacing |
|
Let me know when you think it's ready. |
|
Hey @Cadair, I have tested the plotting with the above modifications in SunPy, and it's working. Since after slicing, we want to reduce the axes that we want to plot, so |
Cadair
approved these changes
Jul 24, 2019
nabobalis
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for APE14 in SunPy for
visualization/animator/image.py.