Move colormap data to .csv files #4433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
cmap-csv
branch
2 times, most recently
from
492a65f
to
4b973cb
Compare
dstansby
changed the title
wtbarnes
approved these changes
Sep 2, 2020
nabobalis
approved these changes
Sep 2, 2020
|
CI failures look un-related; I won't merge as is my PR, but if anyone else wants to this has two approvals. |
|
👏 thanks @dstansby this had been bugging me for a long time! I was going to suggest to add some metadata as headers on the csv files so there's no need to depend on the filename to know which instrument it's for or where/how the colour table had been created but it was merged already. I suppose we can create an issue for that. |
|
Yes, please do open an issue, that would be a very nice thing to do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #3885. This moves some colormap data into their own .csv files which makes them easier to use/human-read.