Return all VSO Query info in the table #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-01-07 16:04:34 UTC |
Cadair
force-pushed
the
vso_response_table
branch
from
c601b0c
to
5b6e2ae
Compare
|
If this passes all the tests, the tests are inadequate 🤣 |
9 tasks
nabobalis
force-pushed
the
vso_response_table
branch
from
5b6e2ae
to
4dc1645
Compare
nabobalis
added
No Backport
nabobalis
reviewed
Dec 30, 2020
| @@ -152,30 +152,30 @@ client for results, in this case VSO.:: | |||
| Results from 1 Provider: | |||
| <BLANKLINE> | |||
| 289 Results from the VSOClient: | |||
There was a problem hiding this comment.
Need to figure out this has become only one column and the rest hidden.
There was a problem hiding this comment.
We can ignore this for now.
nabobalis
reviewed
Dec 30, 2020
nabobalis
reviewed
Dec 30, 2020
nabobalis
reviewed
Dec 30, 2020
nabobalis
reviewed
Jan 4, 2021
Cadair
force-pushed
the
vso_response_table
branch
from
bb22391
to
4fd1c8c
Compare
Cadair
removed
the
No Backport
nabobalis
approved these changes
Jan 5, 2021
dstansby
reviewed
Jan 5, 2021
Cadair
force-pushed
the
vso_response_table
branch
from
08fe870
to
15d6d80
Compare
Closed
Cadair
force-pushed
the
vso_response_table
branch
from
15d6d80
to
7ef2f16
Compare
Cadair
force-pushed
the
vso_response_table
branch
from
7ef2f16
to
f9e5adb
Compare
Cadair
force-pushed
the
vso_response_table
branch
from
f9e5adb
to
69e8d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4750
This returns all values present in the response from the VSO apart from fileid.