-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug with lower case units in opening fits file #5970
Conversation
Hello @nabobalis! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! Comment last updated at 2022-03-16 22:44:13 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful 10/10
Co-authored-by: Stuart Mumford <stuart@cadair.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 3.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick caae6a38c592108470783d11df95bbd8ec823305 a2843c57f78943eafb4d565e9d5b96ff01f4e815 dfd6cd62ccd598bb5b9daf335521214d85d66c56 23deb0b2f43f5c34625cbe3bcc922bf4c775b2d0 259cdb7261a6e40e09700638631e1142fde7d467 3db4b725dd0b6791f4a70c58e165d5d6c2d0cdd6
# Create a new branch with these backported commits.
git checkout -b backport-5970-to-3.0
# Push it to GitHub.
git push --set-upstream origin backport-5970-to-3.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
The function was not changed in 3.0, only 3.1 |
Since allowing people to actual units is too far for sunpy.