-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip dim>=3 data when reading CDF files #5975
Conversation
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
I feel like this is worth a changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should get a changelog entry.
Do you need me to do something for that? 🤔 |
It is something you can do (following: https://github.com/sunpy/sunpy/blob/main/changelog/README.rst) otherwise we can do it for you. |
Okay, I added changelog/5975.bugfix.rst to this PR:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 3.1
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 9830d2bfa6604318aa06c81ad9035148d089cb4a ec61749cf12865c1b2e7749bdd367e7a4450314d 9eb01ce9eea43512cc928b17c6d79ac06dce0ece
# Create a new branch with these backported commits.
git checkout -b backport-5975-to-3.1
# Push it to GitHub.
git push --set-upstream origin backport-5975-to-3.1
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
PR Description
Fixes #5869. When reading CDF files, now variables with more than 2 dimensions (respectively dependencies) are skipped and a user warning is provided. This allows to at least read the 1- and 2-dimensional data of the corresponding CDF file (instead of just crashing). This is needed e.g. for charged particle data obtained by Parker Solar Probe's ISOIS instrument.
PR Checklist
pytest
passes).Fixes #XXXX -
orCloses #XXXX -
comment to auto-close the issue that your PR addresses