-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manual linking APIs #1317
Conversation
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate at least one test to exercise linkIdentityToUser
which can be tested in isolation, no need for a whole request-response setup.
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
…otrue into km/feat-link-identity
05c7b27
to
3b0b550
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
🎉 This PR is included in version 2.121.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Is it possible to test this locally? It doesn't seem as though any set of env variables or config.toml changes enable us to :( |
What kind of change does this PR introduce?
GET /user/identities/authorize
which is an endpoint to initiate the manual linking process and can only be invoked if the user is authenticatedGET /user/identities/authorize
functions similarly toGET /authorize
where the user needs to login to the new oauth identity in order to link the identityDetails
LinkingTargetId
is introduced in the oauth state to store the linking target user ID. This ID will be used in the callback to determine the target user to link the candidate identity used