refactor: pass GrantParams object to issueRefreshToken

[hf]

Passes an empty models.GrantParams object to issueRefreshToken as this is going to be used by SAML / MFA.

[kangmingtay]

@hf why would SAML and MFA need this again?

[hf]

@hf why would SAML and MFA need this again?

So that you can pass parameters for the session such as duration, factor ID, provider ID, etc.

[kangmingtay]

@hf hmm why are we passing GrantParams into the models/refresh_tokens.go methods (https://github.com/supabase/gotrue/blob/master/models/refresh_token.go#L101)? shouldn't they be tied to the models/sessions.go instead?

[hf]

@hf hmm why are we passing GrantParams into the models/refresh_tokens.go methods (https://github.com/supabase/gotrue/blob/master/models/refresh_token.go#L101)? shouldn't they be tied to the models/sessions.go instead?

Good point. Let me dig around.

[hf]

@hf hmm why are we passing GrantParams into the models/refresh_tokens.go methods (https://github.com/supabase/gotrue/blob/master/models/refresh_token.go#L101)? shouldn't they be tied to the models/sessions.go instead?

Good point. Let me dig around.

OK, so today in the code the concept of a session starts on the issuance of the first refresh token. This should be refactored -- but it's going to be a bigger change. Until that happens, we need some way of passing parameters for the session / refresh token, and this is the way today.

[github-actions]

🎉 This PR is included in version 2.16.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀