-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow gotrue to work with multiple custom domains #999
Conversation
3864668
to
5cd5daf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good, but how does it work with SAML? What are the SAML URLs advertized when you get the metadata?
@hf good catch, we can always display the current |
Thanks for your patience - generally LGTM as well. There's quite a bit of overlap with the PKCE PR - do. you want to get this in first? Will save quite a bit of conflict resolution If we haven't yet we should also test this out with a proxy server |
Co-authored-by: Joel Lee <lee.yi.jie.joel@gmail.com>
@J0 sounds good - lemme finish up the deployment plan first to make sure that it won't break any existing projects
I managed to test this out by editing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, I'd just reconsider the hostname allow list as I don't think it does much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This PR is included in version 2.67.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
With #999 custom domains were introduced, however for OAuth, the redirect URLs should in fact be the ones specified in the config and not ones interpreted from the `X-Forwarded-Host` header.
What kind of change does this PR introduce?