-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inbucket to local setup #78
Conversation
Last commit fixes the above issue I had. Currently |
Great progress! 😎 Maybe you want to allow to set custom port for GOTRUE_SITE_URL as well. This is the site you'll be redirected to, right? |
I went ahead and made inbucket opt-in (i.e. only when you specify
+1, but I'd do this after the OSS dashboard for this one, as I'd like to avoid designing the config up front. It does mean you wouldn't be redirected automatically, but at least you can confirm emails, which is at least something I guess... |
Great work. I'll test after lunch here 🙏🏼 |
Looks pretty good @soedirgo . A couple of things though
If I had any golang skills then I'd go ahead and do it but I don't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good from my point of view !
Thanks! Re: point 2 above, there actually isn't any space after it, so not sure why it underlined it. |
🎉 This PR is included in version 0.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@mr-bjerre @soedirgo I am trying to use inbucket/inbucket:latest docker image as part of supabase docker compose. While doing so I get following error when I signup for a user by calling
When I use docker container using I was wondering how you are able to bypass this requirement. I went through I am using exactly the same docker image and yet I keep facing this issue. |
I think that might be the issue. The CLI uses Btw, you might want to consider raising the issue on supabase/supabase instead as the setup is different. Also you may have better luck trying this setup, though we only use it for smoke tests. |
Thanks a ton @soedirgo. You were right. It was indeed the
Sure will do that. I guess this will still be an issue once inbucket is upgraded to |
Fixes #71
I've never written in Go so forgive me if this is bad. It seems to be working for me so that's a good start at least. There is one issue though; the generated link which is captured by inbucket have a wrong domain.
It is
but it should be