Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update functions template to remove deprecated serve #1504

Merged
merged 2 commits into from Sep 19, 2023

Conversation

eifr
Copy link
Contributor

@eifr eifr commented Sep 19, 2023

What kind of change does this PR introduce?

update template of new function as serve from http/server.ts is deprecated.

image

What is the current behavior?

import { serve } from "https://deno.land/std@0.201.0/http/server.ts"; is being used to serve

What is the new behavior?

Deno.serve() will be used for functions as it's what recommended from Deno

@eifr eifr requested a review from a team as a code owner September 19, 2023 06:58
@coveralls
Copy link

coveralls commented Sep 19, 2023

Pull Request Test Coverage Report for Build 6232743560

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 56.661%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6232695550: -0.03%
Covered Lines: 4985
Relevant Lines: 8798

💛 - Coveralls

@eifr eifr changed the title Update index.ts Update functions template Sep 19, 2023
@laktek
Copy link
Contributor

laktek commented Sep 19, 2023

Nice! thanks for the contribution @eifr

@sweatybridge sweatybridge changed the title Update functions template chore: update functions template to remove deprecated serve reference Sep 19, 2023
@sweatybridge sweatybridge changed the title chore: update functions template to remove deprecated serve reference chore: update functions template to remove deprecated serve Sep 19, 2023
@sweatybridge sweatybridge changed the title chore: update functions template to remove deprecated serve fix: update functions template to remove deprecated serve Sep 19, 2023
@sweatybridge sweatybridge enabled auto-merge (squash) September 19, 2023 07:59
@sweatybridge sweatybridge merged commit ab33260 into supabase:main Sep 19, 2023
8 checks passed
@eifr eifr deleted the patch-1 branch September 19, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants