fix: change the status code emitted when an idle timeout occurs for a…

… worker (#349) * fix: change the status code emitted when an idle timeout occurs for a worker * stamp: missing changes
supabase · May 23, 2024 · 8ff5c47 · 8ff5c47
1 parent 85b5c4e
commit 8ff5c47
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/crates/base/src/rt_worker/worker_ctx.rs b/crates/base/src/rt_worker/worker_ctx.rs
@@ -168,8 +168,7 @@ async fn handle_request(
     let res = tokio::select! {
         resp = request_sender.send_request(req) => resp,
         _ = maybe_cancel_fut => {
-            // XXX(Nyannyacha): Should we add a more detailed message?
-            Ok(emit_status_code(http::StatusCode::REQUEST_TIMEOUT, None, true))
+            Ok(emit_status_code(http::StatusCode::GATEWAY_TIMEOUT, None, false))
         }
     };
 

diff --git a/crates/base/tests/integration_tests.rs b/crates/base/tests/integration_tests.rs
@@ -1701,7 +1701,7 @@ async fn test_request_idle_timeout_no_streamed_response(maybe_tls: Option<Tls>)
         request_builder,
         maybe_tls,
         (|resp| async {
-            assert_eq!(resp.unwrap().status().as_u16(), StatusCode::REQUEST_TIMEOUT);
+            assert_eq!(resp.unwrap().status().as_u16(), StatusCode::GATEWAY_TIMEOUT);
         }),
         TerminationToken::new()
     );