fix: populate details on FetchError

supabase · Apr 18, 2023 · 1e2981f · 1e2981f
1 parent 320ac92
commit 1e2981f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/PostgrestBuilder.ts b/src/PostgrestBuilder.ts
@@ -150,10 +150,10 @@ export default abstract class PostgrestBuilder<Result>
     if (!this.shouldThrowOnError) {
       res = res.catch((fetchError) => ({
         error: {
-          message: `FetchError: ${fetchError.message}`,
-          details: '',
+          message: `${fetchError?.name ?? 'FetchError'}: ${fetchError?.message}`,
+          details: `${fetchError?.stack ?? ''}`,
           hint: '',
-          code: fetchError.code || '',
+          code: `${fetchError?.code ?? ''}`,
         },
         data: null,
         count: null,

diff --git a/test/transforms.ts b/test/transforms.ts
@@ -247,20 +247,23 @@ test('abort signal', async () => {
   const ac = new AbortController() as globalThis.AbortController
   ac.abort()
   const res = await postgrest.from('users').select().abortSignal(ac.signal)
-  expect(res).toMatchInlineSnapshot(`
+  expect(res).toMatchInlineSnapshot(
+    { error: { details: expect.any(String) } },
+    `
     Object {
       "count": null,
       "data": null,
       "error": Object {
         "code": "",
-        "details": "",
+        "details": Any<String>,
         "hint": "",
-        "message": "FetchError: The user aborted a request.",
+        "message": "AbortError: The user aborted a request.",
       },
       "status": 0,
       "statusText": "",
     }
-  `)
+  `
+  )
 })
 
 // test('geojson', async () => {