fix: insert w/ empty body can't have columns param

supabase · May 24, 2021 · e14461c · e14461c
1 parent 791dc09
commit e14461c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/lib/PostgrestQueryBuilder.ts b/src/lib/PostgrestQueryBuilder.ts
@@ -109,8 +109,10 @@ export default class PostgrestQueryBuilder<T> extends PostgrestBuilder<T> {
 
     if (Array.isArray(values)) {
       const columns = values.reduce((acc, x) => acc.concat(Object.keys(x)), [] as string[])
-      const uniqueColumns = [...new Set(columns)]
-      this.url.searchParams.set('columns', uniqueColumns.join(','))
+      if (columns.length > 0) {
+        const uniqueColumns = [...new Set(columns)]
+        this.url.searchParams.set('columns', uniqueColumns.join(','))
+      }
     }
 
     return new PostgrestFilterBuilder(this)

diff --git a/test/basic.ts b/test/basic.ts
@@ -239,3 +239,8 @@ test('insert includes columns param', async () => {
   const client = postgrest.from('users').insert([{ foo: 1 }, { bar: 2 }])
   expect((client as any).url.searchParams.get('columns')).toMatchInlineSnapshot(`"foo,bar"`)
 })
+
+test('insert w/ empty body has no columns param', async () => {
+  const client = postgrest.from('users').insert([{}, {}])
+  expect((client as any).url.searchParams.has('columns')).toBeFalsy()
+})