Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: proposal to refactor the library with some additional exports #119

Merged
merged 2 commits into from Oct 19, 2020
Merged

refactor: proposal to refactor the library with some additional exports #119

merged 2 commits into from Oct 19, 2020

Conversation

kiwicopple
Copy link
Member

Refactor

  • added some additional exports which I need in supabase-js
  • Refactored the code - this is an opinion, interested to get your thoughts @soedirgo. Basically I move each of the key classes into their own file - more consistent with the other libraries. Is there any reason it was originally all in one builder.js file?

soedirgo
soedirgo approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@soedirgo soedirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Basically I move each of the key classes into their own file

Yep, this is fine. I thought about splitting off filters but was worried about cyclic imports--seems like it's not an issue.

@soedirgo soedirgo merged commit 4ea3e12 into master Oct 19, 2020
@soedirgo soedirgo deleted the refactor/include_exports branch October 19, 2020 21:24
@kiwicopple kiwicopple mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo soedirgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiwicopple @soedirgo