-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace replication poller process sleep with send_after #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
7eeddfb
to
59fe3f3
Compare
59fe3f3
to
347e215
Compare
chasers
approved these changes
Jan 18, 2023
w3b6x9
added a commit
that referenced
this pull request
Jan 19, 2023
* fix: don't update syn meta if the node is mismatched (#433) * update multiplayer demo MAX_ROOM_USERS to 50 * fix: drop LHR and GRU (#436) * feat: footer improvements (#429) * feat: display the count of connected tenants in metrics (#418) * fix: don't try to stop the not alive pid in the resolver (#417) * fix: increase read replica pool size * feat: default realtime-dev JWT secret to API_JWT_SECRET env var value * chore(deps): bump json5 from 1.0.1 to 1.0.2 in /demo Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * feat: default Repo with_dynamic_repo name to nil and pool_size to 1 (#423) * fix: looks for the PR number after # symbol (#425) * Add defaults to current fields to reflect db schema * Add max_bytes_per_second and max_channels_per_client fields * Add max_joins_per_second to schema * Add db limits to socket * Use db limits in channel * fix: tests * fix: do not block a registration process (#426) * fix: add http checks * feat: stop connection to a tenant's db if there are no connected users for 10 minutes. (#428) * feat: add short_node_id helper * Use new helper in Realtime.PromEx * feat: add version to footer and use short node id Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: abc3 <sts@abc3.dev> Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Bo Xie <5532241+w3b6x9@users.noreply.github.com> * fix: switch to aws roles * chore: update staging branch to main and prod branch to release * Add sjc replica (#441) * fix: load sjc replica from DB_HOST_REPLICA_SJC env var (#443) * Version is compiled now (#444) * Bump version * fix: replace replication poller process sleep with send_after (#447) * feat: show latency on db events on inspector (#450) * Show latency on db events on inspector * Round to seconds for now Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: abc3 <sts@abc3.dev> Co-authored-by: Chase Granberry <chase@logflare.app> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Inian <inian1234@gmail.com>
chasers
added a commit
that referenced
this pull request
Feb 6, 2023
* fix: don't update syn meta if the node is mismatched (#433) * update multiplayer demo MAX_ROOM_USERS to 50 * fix: drop LHR and GRU (#436) * feat: footer improvements (#429) * feat: display the count of connected tenants in metrics (#418) * fix: don't try to stop the not alive pid in the resolver (#417) * fix: increase read replica pool size * feat: default realtime-dev JWT secret to API_JWT_SECRET env var value * chore(deps): bump json5 from 1.0.1 to 1.0.2 in /demo Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * feat: default Repo with_dynamic_repo name to nil and pool_size to 1 (#423) * fix: looks for the PR number after # symbol (#425) * Add defaults to current fields to reflect db schema * Add max_bytes_per_second and max_channels_per_client fields * Add max_joins_per_second to schema * Add db limits to socket * Use db limits in channel * fix: tests * fix: do not block a registration process (#426) * fix: add http checks * feat: stop connection to a tenant's db if there are no connected users for 10 minutes. (#428) * feat: add short_node_id helper * Use new helper in Realtime.PromEx * feat: add version to footer and use short node id Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: abc3 <sts@abc3.dev> Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Bo Xie <5532241+w3b6x9@users.noreply.github.com> * fix: switch to aws roles * chore: update staging branch to main and prod branch to release * Add sjc replica (#441) * fix: load sjc replica from DB_HOST_REPLICA_SJC env var (#443) * Version is compiled now (#444) * Bump version * fix: replace replication poller process sleep with send_after (#447) * feat: show latency on db events on inspector (#450) * Show latency on db events on inspector * Round to seconds for now * fix: prepend inspector latency with tilde (#451) * fix: update SLOT_NAME_SUFFIX to capture first 7 commit SHA chars * docs: add WebSocket URL for local and prod in README * fix: make rlimit configurable by env var (#460) * fix: make rlimit configurable by env var * chore: fix unbound variable * feat: add in op for filter and enable filter on delete records (#461) * feat: add in op when filtering for values * feat: enable filtering on delete records * High res commit timestamps * High res latency on Postgres payloads * toFixed(1) * Footer precision to match multiplayer.dev * Init footer latency to 0.0 * Use ISO8601 with millis * fix: update walrus db change ms timestamp migration * fix: grammar/spelling changes (#465) * Grammar/spelling changes * "realtime" not "real-time" * Revert * Support `in` filter when parsing subscription params * Use PostgREST syntax * Fix test * feat: wrap 'in' filter value with curly brackets * `bad` is not a real filter, why use it as an example? * Sort region nodes by node name * Adds a doc * Consolidate launch_node fn and add logging * feat: use regex for 'in' filter parentheses value * Map "sea" to SJC database * Change regions map `fra` to `lhr` and `sjc` to `sea` * Use node short id and put region on status page * Handle nohost for tests * Include region in latency payloads * Remove extra Logger statement * Short node name only needed with an ipv6 address * Usage Logger server init * Telem usage logger * Working * Make counting more obvious in realtime channel * Metric for Channel events * Optionally execute telemetry from a `RateCounter` * Cleanup * Cleanup * List tenants for a node only * Start Realtime.Tenants module * Change :all limiter key to :plug because that's what it is * Fix test * Changes limiter keys to be more obvious * Fix tests * Unused variables * feat: admin tenants index (#442) * feat: list and sort tenants * Reactive filter and sorting is working * Show important limits on tenants admin list * fix: log badrpc reason --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: abc3 <sts@abc3.dev> Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Bo Xie <5532241+w3b6x9@users.noreply.github.com> Co-authored-by: Inian <inian1234@gmail.com> Co-authored-by: Han Qiao <qiao@supabase.io>
chasers
added a commit
that referenced
this pull request
Feb 6, 2023
* fix: don't update syn meta if the node is mismatched (#433) * update multiplayer demo MAX_ROOM_USERS to 50 * fix: drop LHR and GRU (#436) * feat: footer improvements (#429) * feat: display the count of connected tenants in metrics (#418) * fix: don't try to stop the not alive pid in the resolver (#417) * fix: increase read replica pool size * feat: default realtime-dev JWT secret to API_JWT_SECRET env var value * chore(deps): bump json5 from 1.0.1 to 1.0.2 in /demo Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * feat: default Repo with_dynamic_repo name to nil and pool_size to 1 (#423) * fix: looks for the PR number after # symbol (#425) * Add defaults to current fields to reflect db schema * Add max_bytes_per_second and max_channels_per_client fields * Add max_joins_per_second to schema * Add db limits to socket * Use db limits in channel * fix: tests * fix: do not block a registration process (#426) * fix: add http checks * feat: stop connection to a tenant's db if there are no connected users for 10 minutes. (#428) * feat: add short_node_id helper * Use new helper in Realtime.PromEx * feat: add version to footer and use short node id Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: abc3 <sts@abc3.dev> Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Bo Xie <5532241+w3b6x9@users.noreply.github.com> * fix: switch to aws roles * chore: update staging branch to main and prod branch to release * Add sjc replica (#441) * fix: load sjc replica from DB_HOST_REPLICA_SJC env var (#443) * Version is compiled now (#444) * Bump version * fix: replace replication poller process sleep with send_after (#447) * feat: show latency on db events on inspector (#450) * Show latency on db events on inspector * Round to seconds for now * fix: prepend inspector latency with tilde (#451) * fix: update SLOT_NAME_SUFFIX to capture first 7 commit SHA chars * docs: add WebSocket URL for local and prod in README * fix: make rlimit configurable by env var (#460) * fix: make rlimit configurable by env var * chore: fix unbound variable * feat: add in op for filter and enable filter on delete records (#461) * feat: add in op when filtering for values * feat: enable filtering on delete records * High res commit timestamps * High res latency on Postgres payloads * toFixed(1) * Footer precision to match multiplayer.dev * Init footer latency to 0.0 * Use ISO8601 with millis * fix: update walrus db change ms timestamp migration * fix: grammar/spelling changes (#465) * Grammar/spelling changes * "realtime" not "real-time" * Revert * Support `in` filter when parsing subscription params * Use PostgREST syntax * Fix test * feat: wrap 'in' filter value with curly brackets * `bad` is not a real filter, why use it as an example? * Sort region nodes by node name * Adds a doc * Consolidate launch_node fn and add logging * feat: use regex for 'in' filter parentheses value * Map "sea" to SJC database * Change regions map `fra` to `lhr` and `sjc` to `sea` * Use node short id and put region on status page * Handle nohost for tests * Include region in latency payloads * Remove extra Logger statement * Short node name only needed with an ipv6 address * Usage Logger server init * Telem usage logger * Working * Make counting more obvious in realtime channel * Metric for Channel events * Optionally execute telemetry from a `RateCounter` * Cleanup * Cleanup * List tenants for a node only * Start Realtime.Tenants module * Change :all limiter key to :plug because that's what it is * Fix test * Changes limiter keys to be more obvious * Fix tests * Unused variables * feat: admin tenants index (#442) * feat: list and sort tenants * Reactive filter and sorting is working * Show important limits on tenants admin list * fix: log badrpc reason * fix: remove Erlang binary notation --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: abc3 <sts@abc3.dev> Co-authored-by: Wen Bo Xie <wenbo.xie3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Bo Xie <5532241+w3b6x9@users.noreply.github.com> Co-authored-by: Inian <inian1234@gmail.com> Co-authored-by: Han Qiao <qiao@supabase.io>
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Replication poller process blocks b/c it's forced to sleep when retrying poller.
What is the new behavior?
Replication poller process sends message to self based on backoff timeout.
Additional context
Updates rand exp backoff max from 2 minutes to 5 seconds.