add id and fullPath to update and upload functions response #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update return interface in upload and update functions StorageFileApi.ts to return id and fullPath since the uploadOrUpdate returns fullPath and id which are used in multiple cases when uploading/updating a file
ssayssa
approved these changes
Dec 12, 2023
|
Thank you @ssayssa |
fenos
approved these changes
Dec 19, 2023
2 tasks
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update return interface in upload and update functions StorageFileApi.ts to return id and fullPath since the uploadOrUpdate returns fullPath and id which are used in multiple cases when uploading/updating a file
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
the id and full path are not returned in the upload and update functions in StorageFileApi.ts
What is the new behavior?
the id and full path are returned in the upload and update functions in StorageFileApi.ts