Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #43 use custom content type parser for application/json and text/plain #44

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

thebengeu
Copy link
Member

What kind of change does this PR introduce?

Pipe the request stream for these content types instead of the default handling. See https://www.fastify.io/docs/latest/ContentTypeParser/.

What is the current behavior?

text/plain and application/json MIME type are uploaded in Storage Buckets as empty files.

What is the new behavior?

text/plain and application/json MIME type are uploaded in Storage Buckets correctly.

So that changes to the Fastify instance will only be reflected in each plugin's scope.
…/plain

Pipe the request stream for these content types instead of the default handling. See https://www.fastify.io/docs/latest/ContentTypeParser/.
@inian
Copy link
Member

inian commented Jul 15, 2021

Nice @thebengeu 🔥

@inian inian merged commit 980e5c6 into master Jul 15, 2021
@inian inian deleted the fix/43_content_type_parser branch July 15, 2021 04:57
@github-actions
Copy link

🎉 This PR is included in version 0.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants