fix(gotrue): remove OtpType deprecation and add assertion to check type for resend method #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
requested changes
Jul 24, 2023
Co-authored-by: Vinzent <vinzent03@proton.me>
dshukertjr
commented
Jul 24, 2023
Vinzent03
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Some
OtpTypeenum values were deprecated in this PR, but it seems like Gotrue server requires the deprecated values in some APIs.This PR removes the deprecated flag so that the users can use the resend method without deprecation warnings.
We can add back the deprecation warnings when the backend properly starts accepting the new
emailtype.Related supabase/auth-js#642
Issue report from user #517 (comment)